Fix compilation with Boost 1.73 #2758
Conversation
The ModelTreeWidget.cc file was using the Boost Bind placeholders, but it was not including boost/bind.hpp . Before Boost 1.73, this was working probably due to transitive includes. Slightly related issue: gazebosim#2757 . Signed-off-by: Silvio Traversaro <[email protected]>
|
we've often found these problems when homebrew-core updates the boost version, but boost 1.73.0 hasn't merged there yet: Homebrew/homebrew-core#53874 thanks for the fix! |
I found this completely by chance by updating a dependency built script for a project (that typically uses a fixed vcpkg version for reproducibility), but indeed it probably make sense to setup a weekly CI job that compile Gazebo and all its dependencies using the latest vcpkg, to early catch these kind of regressions, I willprobably set it up. The nice aspects is that for repos that have official ports on vcpkg we get this report even before the dependency is updated, see for example gazebosim/gz-msgs#56 . |
In particular, use a backport of gazebosim/gazebo-classic#2758 .
The
ModelTreeWidget.ccfile was using the Boost Bind placeholders, but it was not includingboost/bind.hpp. Before Boost 1.73, this was working probably due to transitive includes.Slightly related issue: #2757 .
This change is required to build Gazebo11 with the latest version of vcpkg.