0 ➡️ 2 #182
Merged
0 ➡️ 2 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport fix for find_path cache confusion Approved-by: Steve Peters <[email protected]> Approved-by: Nate Koenig <[email protected]> Approved-by: Louise Poubel <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: seanyen <[email protected]>
* Part of gazebo-tooling/release-tools#203 * Disable long-running buildsystem tests by default (#97) (#100) * backport triage and labeler Signed-off-by: Steve Peters <[email protected]> Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
github-actions
bot
added
Gazebo 1️1️
scpeters
reviewed
Aug 24, 2021
adlarkin
reviewed
Aug 24, 2021
Changelog.md
Outdated
Comment on lines
9
to
11
| 1. Fix bad INCLUDE_DIRS cache confusion | ||
| * [Pull request #182](https:/ignitionrobotics/ign-cmake/pull/182) | ||
| * [Commit 5320ac6](https:/ignitionrobotics/ign-cmake/commit/5320ac64c23e379562f9abfccf5eea69456cb5c1) |
There was a problem hiding this comment.
This was a backport from ign-cmake2, so do we need to add it to the changelog of ign-cmake2 since it's already in ign-cmake2? I'm not sure which particular commit in ign-cmake2 added this because it looks like it was done while we were still on BitBucket, but the content is there if you look at the ign-cmake2 branch
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/0_to_2
branch
from
4c7fde3
to
40b6c8e
Compare
scpeters
approved these changes
Aug 24, 2021
j-rivero
approved these changes
Aug 25, 2021
7 tasks
srmainwaring
pushed a commit
to srmainwaring/gz-cmake
that referenced
this pull request
Mar 1, 2022
* make the OGRE plugin path discovery portable (gazebosim#101) * Remove bitbucket-pipelines.yml (gazebosim#181) Signed-off-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-cmake0toign-cmake2(ign-cmake1is EOL)Branch comparison: ign-cmake2...ign-cmake0
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
https:/osrf/buildfarmer/issues/224