Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Bump main to 4.0.0~pre1 #296

Merged
merged 1 commit into from
Aug 8, 2022
Merged

⬆️ Bump main to 4.0.0~pre1 #296

merged 1 commit into from
Aug 8, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina
Bump main to 4.0.0~pre1
81f0996 
Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 2, 2022
@chapulina chapulina mentioned this pull request Aug 2, 2022
Open
@chapulina chapulina removed the 🌱 garden Ignition Garden label Aug 2, 2022
@chapulina
Copy link
Contributor Author

We need to fix the Homebrew CI, it's still relying on the ignition aliases

Warning: No available formula with the name "ignition-cmake4".

@chapulina chapulina mentioned this pull request Aug 3, 2022
Merged
@chapulina chapulina changed the title Bump main to 4.0.0~pre1 ⬆️ Bump main to 4.0.0~pre1 Aug 5, 2022
@chapulina chapulina enabled auto-merge (squash) August 8, 2022 16:35
jennuine
jennuine approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, found a couple other places:

@chapulina chapulina merged commit 332b976 into main Aug 8, 2022
@chapulina chapulina deleted the chapulina/4/bump branch August 8, 2022 21:55
@jennuine
Copy link
Contributor

jennuine commented Aug 8, 2022

oohh no I didn't see that it was set to auto-merge...

@jennuine jennuine mentioned this pull request Aug 8, 2022
Merged
@chapulina chapulina mentioned this pull request Aug 8, 2022
Closed
8 tasks
@chapulina
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @jennuine