Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include windows instructions in examples README.md #190

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 26, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Improved examples/README.md instrucctions to compile examples on Windows

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from mjcarroll as a code owner March 26, 2021 18:45
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #190 (18d48e1) into main (d36a0fa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files          73       73           
  Lines       10346    10346           
=======================================
  Hits         7811     7811           
  Misses       2535     2535           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36a0fa...18d48e1. Read the comment docs.

@chapulina chapulina added documentation Improvements or additions to documentation Windows Windows support labels Mar 26, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chapulina chapulina merged commit 2f2b229 into main Mar 26, 2021
@chapulina chapulina deleted the ahcorde/examples/windows branch March 26, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants