ign -> gz CMake, Python, Partial Source, and File Migrations : gz-common #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
32 tasks
|
@osrf-jenkins run tests please! |
1 similar comment
|
@osrf-jenkins run tests please! |
methylDragon
force-pushed
the
ci_matching_branch/file_and_source_migration
branch
from
969d80c
to
a4ba4cf
Compare
|
@osrf-jenkins run tests please! |
1 similar comment
|
@osrf-jenkins run tests please! |
chapulina
suggested changes
Jul 13, 2022
methylDragon
force-pushed
the
ci_matching_branch/file_and_source_migration
branch
3 times, most recently
from
976588c
to
cece49d
Compare
Signed-off-by: methylDragon <[email protected]>
methylDragon
added a commit
that referenced
this pull request
Jul 13, 2022
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
ci_matching_branch/file_and_source_migration
branch
from
cece49d
to
6506cdf
Compare
methylDragon
added a commit
that referenced
this pull request
Jul 13, 2022
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
ci_matching_branch/file_and_source_migration
branch
from
6506cdf
to
a186084
Compare
methylDragon
added a commit
that referenced
this pull request
Jul 13, 2022
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
ci_matching_branch/file_and_source_migration
branch
from
a186084
to
71754e2
Compare
chapulina
suggested changes
Jul 14, 2022
Migration.md
Outdated
| @@ -75,7 +75,7 @@ release will remove the deprecated code. | |||
| ### Modifications | |||
|
|
|||
| 1. Corrected `BAYER_RGGR8` to `BAYER_BGGR8` in `PixelFormatName` and | |||
| `PixelFormatType` located in `graphics/include/ignition/common/Image.hh`. | |||
| `PixelFormatType` located in `graphics/gz/common/Image.hh`. | |||
There was a problem hiding this comment.
Suggested change
| `PixelFormatType` located in `graphics/gz/common/Image.hh`. | |
| `PixelFormatType` located in `graphics/include/gz/common/Image.hh`. |
There was a problem hiding this comment.
Oops, fixed! 92a820c
| @@ -41,7 +41,7 @@ if (UNIX) | |||
| PASS_REGULAR_EXPRESSION "is not a base class of") | |||
|
|
|||
| set_tests_properties(STATIC_ASSERT_plugin_not_global_ns PROPERTIES | |||
| PASS_REGULAR_EXPRESSION "IGN_macro_must_be_used_in_global_namespace") | |||
| PASS_REGULAR_EXPRESSION "GZ_macro_must_be_used_in_global_namespace") | |||
There was a problem hiding this comment.
I think this is causing test failures:
[100%] Building CXX object test/static_assertions/CMakeFiles/plugin_not_global_ns.dir/plugin_not_global_ns.cc.o
In file included from /github/workspace/include/ignition/common/PluginMacros.hh:23,
from /github/workspace/test/static_assertions/plugin_not_global_ns.cc:22:
/github/workspace/include/ignition/common/detail/PluginMacros.hh:71:9: [Censored by testrunner.bash]: '::IGN_macro_must_be_used_in_global_namespace' has not been declared; did you mean 'ns::IGN_macro_must_be_used_in_global_namespace'?
71 | ::IGN_macro_must_be_used_in_global_namespace>::value, \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
Fixed! 92a820c
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
ci_matching_branch/file_and_source_migration
branch
from
71754e2
to
92a820c
Compare
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 77.83% 77.81% -0.03%
==========================================
Files 85 85
Lines 10771 10770 -1
==========================================
- Hits 8384 8381 -3
- Misses 2387 2389 +2
Continue to review full report at Codecov.
|
chapulina
approved these changes
Jul 15, 2022
methylDragon
added a commit
that referenced
this pull request
Jul 15, 2022
Signed-off-by: methylDragon <[email protected]>
luca-della-vedova
pushed a commit
that referenced
this pull request
Jul 27, 2022
Signed-off-by: methylDragon <[email protected]>
luca-della-vedova
pushed a commit
that referenced
this pull request
Jul 27, 2022
Signed-off-by: methylDragon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: gazebo-tooling/release-tools#765