Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage ignore file #394

Merged
merged 7 commits into from
Jul 27, 2022
Merged

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy [email protected]

New feature

Part of gz-sim#1575

Summary

Add coverage.ignore.in to ignore vendor code in code coverage report. See gz-cmake#279 for detail.

Ignore profiler/src/Remotery and graphics/src/tiny_obj_loader.h

Increase the coverage from ~74% -> ~79%

Before
20220713151601

After
20220713150911

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 13, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jul 13, 2022
@chapulina chapulina added the QA Quality assurance. label Jul 13, 2022
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #394 (3358efb) into ign-common3 (88bde3d) will increase coverage by 1.89%.
The diff coverage is n/a.

❗ Current head 3358efb differs from pull request most recent head a54a6da. Consider uploading reports for the commit a54a6da to get more accurate results

@@               Coverage Diff               @@
##           ign-common3     #394      +/-   ##
===============================================
+ Coverage        76.63%   78.52%   +1.89%     
===============================================
  Files               73       72       -1     
  Lines            10425     9244    -1181     
===============================================
- Hits              7989     7259     -730     
+ Misses            2436     1985     -451     
Impacted Files Coverage Δ
graphics/src/tiny_obj_loader.h

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88bde3d...a54a6da. Read the comment docs.

coverage.ignore.in Outdated Show resolved Hide resolved
coverage.ignore.in Outdated Show resolved Hide resolved
@AzulRadio AzulRadio marked this pull request as ready for review July 25, 2022 22:21
@AzulRadio AzulRadio removed the needs upstream release Blocked by a release of an upstream library label Jul 25, 2022
@jennuine jennuine added the needs upstream release Blocked by a release of an upstream library label Jul 25, 2022
@jennuine jennuine mentioned this pull request Jul 25, 2022
5 tasks
@jennuine jennuine removed the needs upstream release Blocked by a release of an upstream library label Jul 26, 2022
@chapulina chapulina merged commit 0f7ec78 into ign-common3 Jul 27, 2022
@chapulina chapulina deleted the azulradio/codecoverage_ignore branch July 27, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 QA Quality assurance.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants