Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for model config dependencies #124

Merged

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Oct 7, 2020

Downloads the dependencies listed in a model.config file, depends on gazebosim/gz-msgs#91

Signed-off-by: John Shepherd [email protected]

@JShep1 JShep1 requested a review from nkoenig as a code owner October 7, 2020 05:50
@JShep1 JShep1 mentioned this pull request Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #124 into jshep1/download_dependencies will decrease coverage by 0.09%.
The diff coverage is 45.45%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           jshep1/download_dependencies     #124      +/-   ##
================================================================
- Coverage                         76.92%   76.82%   -0.10%     
================================================================
  Files                                19       19              
  Lines                              2548     2559      +11     
================================================================
+ Hits                               1960     1966       +6     
- Misses                              588      593       +5     
Impacted Files Coverage Δ
src/FuelClient.cc 67.09% <45.45%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cfba8...90e1069. Read the comment docs.

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Oct 8, 2020
@JShep1 JShep1 merged commit f7fd8eb into jshep1/download_dependencies Oct 12, 2020
@JShep1 JShep1 deleted the jshep1/add_model_config_dep_download branch October 12, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants