Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6 ➡️ 7 #238

Merged
merged 8 commits into from
Mar 7, 2022
Merged

6 ➡️ 7 #238

merged 8 commits into from
Mar 7, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-fuel-tools6 to ign-fuel-tools7

Branch comparison: ign-fuel-tools7...ign-fuel-tools6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 8 commits January 10, 2022 12:33
@chapulina
Improve and fix ResultType tests (#225)
e88d5e6 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Move test cache to build folder (#222)
3ea0844 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
More checks when manipulating file system in tests (#227)
ae90993 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
4 ➡️ 6
b58280d 
Signed-off-by: Louise Poubel <[email protected]>
@scpeters
Fix trailing slashes in failing tests (#237)
2a8f8e6 
Follow up to gazebosim/gz-common#275

Signed-off-by: Steve Peters <[email protected]>
@chapulina
Merge branch 'ign-fuel-tools6' into chapulina/4_to_6
5048650
@chapulina
4 ➡️ 6 (#234)
f98c839 
* Improve and fix ResultType tests (#225)

Signed-off-by: Louise Poubel <[email protected]>

* Move test cache to build folder (#222)

Signed-off-by: Louise Poubel <[email protected]>

* More checks when manipulating file system in tests (#227)

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
6 ➡️ 7
a1b382b 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mjcarroll March 7, 2022 18:07
@chapulina chapulina requested a review from nkoenig as a code owner March 7, 2022 18:07
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022 •
edited
Loading

Codecov Report

Merging #238 (ed636a9) into ign-fuel-tools7 (be6fca2) will not change coverage.
The diff coverage is n/a.

❗ Current head ed636a9 differs from pull request most recent head a1b382b. Consider uploading reports for the commit a1b382b to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-fuel-tools7     #238   +/-   ##
================================================
  Coverage            75.39%   75.39%           
================================================
  Files                   20       20           
  Lines                 2829     2829           
================================================
  Hits                  2133     2133           
  Misses                 696      696

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d217ee5...a1b382b. Read the comment docs.

@scpeters scpeters merged commit 2c29dd7 into ign-fuel-tools7 Mar 7, 2022
@scpeters scpeters deleted the chapulina/6_to_7 branch March 7, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @scpeters