Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition -> Gazebo #276

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Ignition -> Gazebo #276

merged 1 commit into from
Jul 15, 2022

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Part of:

Summary

Updated links and naming

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine added tests Broken or missing tests / testing infra QA Quality assurance. labels Jul 14, 2022
@jennuine jennuine requested a review from chapulina July 14, 2022 23:53
@jennuine jennuine requested a review from nkoenig as a code owner July 14, 2022 23:53
@jennuine jennuine self-assigned this Jul 14, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #276 (c53ba47) into ign-fuel-tools4 (5146db9) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ign-fuel-tools4     #276   +/-   ##
================================================
  Coverage            76.15%   76.15%           
================================================
  Files                   19       19           
  Lines                 2718     2718           
================================================
  Hits                  2070     2070           
  Misses                 648      648           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5146db9...c53ba47. Read the comment docs.

README.md Show resolved Hide resolved
@jennuine jennuine dismissed ahcorde’s stale review July 15, 2022 15:03

This isn't implemented in citadel, only in garden. If it's backported later on we can update it then

@chapulina chapulina merged commit 0eb55f9 into ign-fuel-tools4 Jul 15, 2022
@chapulina chapulina deleted the jennuine/readme_updates branch July 15, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 QA Quality assurance. tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants