Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to README and installation #127

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Updates to README and installation #127

merged 2 commits into from
Sep 29, 2020

Conversation

chapulina
Copy link
Contributor

  • Ignition Robotics -> Ignition
  • Moved testing into the installation tutorial, because it's lost without context on the top page
  • Added a link to the Ignition installation docs (related to Install instructions using src for all ign libraries gz-sim#124)
  • Added documentation and code checker instructions
  • Added Homebrew installation instructions

@chapulina chapulina added documentation Improvements or additions to documentation 🔮 dome Ignition Dome macOS macOS support labels Sep 26, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020 •
edited
Loading

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   63.23%   63.23%           
=======================================
  Files          20       20           
  Lines        2592     2592           
=======================================
  Hits         1639     1639           
  Misses        953      953

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77b0ed...f4b1480. Read the comment docs.

@chapulina chapulina mentioned this pull request Sep 29, 2020
Merged
JShep1
JShep1 approved these changes Sep 29, 2020
View reviewed changes
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chapulina chapulina merged commit 17e5dd6 into master Sep 29, 2020
@chapulina chapulina deleted the chapulina/docs branch September 29, 2020 17:55
@chapulina chapulina mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JShep1 JShep1 JShep1 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome macOS macOS support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @JShep1