Floating and standalone plugins respect minimum dimensions #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set parentItem after resizing the dialog * Create minimum height and width card properties * Set height and width of card on adding a child plugin * Enforce minimum dimensions on floating plugin resize Signed-off-by: Sarathkrishnan Ramesh <[email protected]>
|
Instead of setting height and width on Component.onCompleted I set the height and width of the card pane when the child plugin is added. This way we don't require to change any of the plugins. |
chapulina
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set parentItem after resizing the dialog
Create minimum height and width card properties
Set height and width of card on adding a child plugin
Enforce minimum dimensions on floating plugin resize
Signed-off-by: Sarathkrishnan Ramesh [email protected]