Change deprecated Qt::MidButton #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #153 +/- ##
=========================================
Coverage 60.16% 60.16%
=========================================
Files 20 20
Lines 2500 2500
=========================================
Hits 1504 1504
Misses 996 996
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some new warnings on macOS:
https://build.osrfoundation.org/job/ignition_gui-ci-pr_any-homebrew-amd64/709/clang/new/
'MidButton' is deprecated: MidButton is deprecated. Use MiddleButton insteadThis is probably only showing on macOS because it uses a newer version of Qt.
In any case
Qt::MiddleButtonhas been an alias forQt::MidButtonfor a long time, since at least Qt4, so this should be a safe change on all platforms.