Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecheck #157

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix codecheck #157

merged 1 commit into from
Dec 18, 2020

Conversation

chapulina
Copy link
Contributor

Satisfy new codechecker when doing make codecheck. That's tested on GitHub actions CI.

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Dec 18, 2020
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #157 (a4aef95) into ign-gui3 (8c63559) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #157   +/-   ##
=========================================
  Coverage     60.31%   60.31%           
=========================================
  Files            20       20           
  Lines          2510     2510           
=========================================
  Hits           1514     1514           
  Misses          996      996           
Impacted Files Coverage Δ
src/plugins/image_display/ImageDisplay.cc 23.27% <ø> (ø)
src/plugins/key_publisher/KeyPublisher.cc 56.52% <ø> (ø)
src/plugins/topic_viewer/TopicViewer.cc 82.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c63559...a4aef95. Read the comment docs.

@chapulina
Copy link
Contributor Author

Codecheck passed on actions and jenkins! Merging!

@chapulina chapulina merged commit c80515d into ign-gui3 Dec 18, 2020
@chapulina chapulina deleted the chapulina/3/codecheck branch December 18, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants