Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Installation #168

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Jan 20, 2021

A retarget of #161 to Citadel

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 20, 2021
@JShep1 JShep1 mentioned this pull request Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #168 (f1610c1) into ign-gui3 (c80515d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #168   +/-   ##
=========================================
  Coverage     60.31%   60.31%           
=========================================
  Files            20       20           
  Lines          2510     2510           
=========================================
  Hits           1514     1514           
  Misses          996      996           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80515d...f1610c1. Read the comment docs.

John Shepherd added 3 commits January 20, 2021 09:25
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just have a couple comments about the README

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@JShep1 JShep1 requested a review from chapulina January 21, 2021 19:09
@chapulina chapulina merged commit e09a4e3 into ign-gui3 Jan 21, 2021
@chapulina chapulina deleted the jshep1/mabelzhang/windows_install_gui3 branch January 21, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants