Improve the height of plugins in the right split

[chapulina]

🦟 Bug fix

Summary

The height of plugins stacked on the right split doesn't always update in a reasonable way. This pull request improves the situation. The following situations use examples/config/layout.config.

• If the window is not large enough to fit all plugins, squish them all to their minimum height and make the split scrollable.
• If the window is large enough to fit all plugins, they are stretched to fill the entire height, and their proportion can be changed dragging the separator.
• Collapsed plugins behave consistently with the above
• Adding / removing plugins also behaves as expected

Checklist

• Signed all commits for DCO
• Added tests: No, because we don't have a good way of testing the view right now 😕
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[codecov]

Codecov Report

Merging #194 (b1daa0b) into ign-gui3 (071a8e4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           ign-gui3     #194   +/-   ##
=========================================
  Coverage     59.03%   59.03%           
=========================================
  Files            23       23           
  Lines          2739     2739           
=========================================
  Hits           1617     1617           
  Misses         1122     1122           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071a8e4...b1daa0b. Read the comment docs.

[scpeters]

I don't really get what's supposed to happen, and I am having trouble reproducing the behavior in your animations

[scpeters]

I don't really get what's supposed to happen, and I am having trouble reproducing the behavior in your animations

I see that the separator is not movable with the current version, but it is movable with this branch

[scpeters]

I don't really get what's supposed to happen, and I am having trouble reproducing the behavior in your animations

I see that the separator is not movable with the current version, but it is movable with this branch

but I don't consistently see the auto-adjusting of size that you mention in the description

[chapulina]

I should have mentioned the issue that this is trying to solve. Without this PR, the plugins are always squished to their minimum heights and don't expand to take up the free space. For example, see how the entity tree is small even though there's a lot of empty space under it:

This also means that the separators are never draggable without this PR, because the widgets are fixed to their minimum heights.

[chapulina]

This issue was brought up here, see how the widget is squished there: gazebosim/gz-sim#534 (review)

[scpeters]

• If the window is large enough to fit all plugins, they are stretched to fill the entire height, and their proportion can be changed dragging the separator.

I think I was misinterpreting what you meant by this. I see the same behavior as in your animations now, so it looks fine enough to me, even if I'm not sure what "stretched to fill the entire height" means

[chapulina]

I'm not sure what "stretched to fill the entire height" means

You can see in my gifs that unless the plugins are collapsed, there's never empty space below them. They are "stretched" to fill the entire column.

Thanks for the quick review!