Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated scale for capsule in Scene3D #215

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Apr 28, 2021

Signed-off-by: Jenn Nguyen [email protected]

🦟 Bug fix

Summary

Extending on the added capsule support from #214, this updates scale for a capsule geometry.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Jenn Nguyen <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Apr 28, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for staying on top of this!

@jennuine jennuine merged commit ffbdb26 into ign-gui5 Apr 29, 2021
@jennuine jennuine deleted the jennuine/capsule_updates branch April 29, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants