Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doc Build Error #266

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Aug 9, 2021

🦟 Bug fix

Fixes #265

Summary

I updated the escaping to match https:/ignitionrobotics/ign-launch/blob/bcb63ff01198569e5c31101131e0374bed1e8672/CMakeLists.txt#L121

I don't know the first thing about CMake, but it seemed to fix the problem.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: David V. Lu <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #266 (aed7f39) into ign-gui5 (cac3da7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui5     #266   +/-   ##
=========================================
  Coverage     66.12%   66.12%           
=========================================
  Files            26       26           
  Lines          3218     3218           
=========================================
  Hits           2128     2128           
  Misses         1090     1090           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac3da7...aed7f39. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I verified that the links to upstream libraries are generated correctly 👍

@chapulina chapulina merged commit 6cdc2f7 into gazebosim:ign-gui5 Aug 9, 2021
@DLu DLu deleted the fix_doc_build_error branch August 9, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Error when building from source
3 participants