Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new GuiEvent HoverOnScene #273

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Create new GuiEvent HoverOnScene #273

merged 2 commits into from
Aug 19, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 18, 2021

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

It publishes the onhover mouse 2D points

Required by:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #273 (34364ba) into main (e8f54e3) will increase coverage by 0.35%.
The diff coverage is 49.09%.

❗ Current head 34364ba differs from pull request most recent head f929e7e. Consider uploading reports for the commit f929e7e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   64.79%   65.14%   +0.35%     
==========================================
  Files          32       32              
  Lines        4508     4525      +17     
==========================================
+ Hits         2921     2948      +27     
+ Misses       1587     1577      -10     
Impacted Files Coverage Δ
include/ignition/gui/GuiEvents.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalScene.cc 59.07% <22.22%> (+1.73%) ⬆️
src/Conversions.cc 100.00% <100.00%> (ø)
src/GuiEvents.cc 100.00% <100.00%> (ø)
src/plugins/scene3d/Scene3D.cc 48.89% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6b225...f929e7e. Read the comment docs.

include/ignition/gui/GuiEvents.hh Outdated Show resolved Hide resolved
@ahcorde ahcorde mentioned this pull request Aug 19, 2021
8 tasks
public: explicit HoverOnScene(const math::Vector2i &_point);

/// \brief Unique type for this event.
static const QEvent::Type kType = QEvent::Type(QEvent::MaxUser - 13);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noob question, why -13? Can this be documented in the comments?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to comment it, because it keeps coming up 😅

tl;dr: gazebo::gui:GuiEvents count up, gui::GuiEvents count down.

See context here: #70 (comment)

@ahcorde ahcorde requested a review from chapulina August 19, 2021 18:12
@ahcorde ahcorde merged commit e8b3d16 into main Aug 19, 2021
@ahcorde ahcorde deleted the ahcorde/events/hoveronscene branch August 19, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants