Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter to the plugin menu #277

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Closes gazebosim/gz-sim#821

Summary

Now that we have so many GUI plugins, it can be tough for users to get to the plugin they want, or to discover existing plugins.

This PR adds a field to the plugin menu so the user can filter plugins by name. This should help getting to plugins more easily.

Test it

Load ign gui or ign gazebo, open the menu, and filter away:

menu_filter

gz_filter

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Sep 1, 2021
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #277 (9c7b4f5) into ign-gui3 (cdc6eac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #277   +/-   ##
=========================================
  Coverage     66.46%   66.46%           
=========================================
  Files            25       25           
  Lines          2949     2949           
=========================================
  Hits           1960     1960           
  Misses          989      989           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc6eac...9c7b4f5. Read the comment docs.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Currently, after you open the plugin menu, the text field needs to be clicked to begin typing. Is there a way to set it so that you can start typing in the text field automatically after clicking the plugin menu?

Signed-off-by: Louise Poubel <[email protected]>
…botics/ign-gui into chapulina/3/menu_filter

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Is there a way to set it so that you can start typing in the text field automatically after clicking the plugin menu?

Great idea, done in 84fbfe7

@chapulina chapulina enabled auto-merge (squash) September 2, 2021 00:08
@chapulina chapulina merged commit 242dd40 into ign-gui3 Sep 2, 2021
@chapulina chapulina deleted the chapulina/3/menu_filter branch September 2, 2021 00:22
@peci1
Copy link
Contributor

peci1 commented Dec 22, 2021

I have the impression that before this PR, the plugins used to be alphabetically sorted in the list. Now they appear in a random order and it's even larger mess than before.

@chapulina
Copy link
Contributor Author

humm yeah you're right, they used to be alphabetically ordered since #71. I'm reopening gazebosim/gz-sim#175

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants