Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing Helpers test on macOS #361

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Attempt at fixing Helpers test on macOS #361

merged 1 commit into from
Mar 2, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Fixes #360, maybe

Summary

Applied the fixes in #244 to Helpers_TEST, maybe that helps.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added bug Something isn't working tests Broken or missing tests / testing infra macOS macOS support labels Mar 1, 2022
@chapulina chapulina requested a review from scpeters March 1, 2022 22:56
@chapulina chapulina requested a review from jennuine as a code owner March 1, 2022 22:56
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #361 (767a2f0) into main (2c46acb) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   63.23%   63.20%   -0.04%     
==========================================
  Files          40       40              
  Lines        5318     5318              
==========================================
- Hits         3363     3361       -2     
- Misses       1955     1957       +2     
Impacted Files Coverage Δ
src/plugins/scene3d/Scene3D.cc 49.62% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3753ef2...767a2f0. Read the comment docs.

@scpeters scpeters merged commit e099634 into main Mar 2, 2022
@scpeters scpeters deleted the chapulina/7/360 branch March 2, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden macOS macOS support tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants