Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransportSceneManager: Prevent freeze when inserted from menu #365

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Currently, the TransportSceneManager freezes the window when inserted from the GUI menu, because it's waiting for an empty transport service for 30 seconds. With this PR:

  • The service and other topics have default values, so the scene manager could potentially work when inserted
  • The service and topics are displayed to the user, so they have an idea of what the plugin is trying to do
  • The service request happens in a separate thread, so the rendering thread isn't blocked for 30 seconds
  • If the user provides invalid topics, don't even subscribe to render events

trans_manager

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Mar 3, 2022
@chapulina chapulina requested a review from jennuine as a code owner March 3, 2022 22:44
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 3, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment about the how to display the topic names

Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@chapulina chapulina requested a review from ahcorde March 4, 2022 02:54
@chapulina chapulina enabled auto-merge (squash) March 4, 2022 17:26
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #365 (7cdf467) into ign-gui6 (ce4c368) will increase coverage by 0.09%.
The diff coverage is 75.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui6     #365      +/-   ##
============================================
+ Coverage     65.39%   65.48%   +0.09%     
============================================
  Files            39       39              
  Lines          5123     5148      +25     
============================================
+ Hits           3350     3371      +21     
- Misses         1773     1777       +4     
Impacted Files Coverage Δ
...s/transport_scene_manager/TransportSceneManager.cc 53.97% <75.75%> (+1.68%) ⬆️
src/plugins/scene3d/Scene3D.cc 49.87% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4c368...7cdf467. Read the comment docs.

@chapulina chapulina merged commit 3d327f6 into ign-gui6 Mar 4, 2022
@chapulina chapulina deleted the chapulina/6/trans_manager_ux branch March 4, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants