Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example running a dialog before the main window #407

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented May 27, 2022

🎉 New feature

Summary

Added a standalone example for how to run a custom dialog before opening the main window.

image

TODO

I created the new Application::CreateMainWindow function as a public version of InitializeMainWindow, and I must be doing something silly wrong because the example fails to compile with "undefined reference". That needs to be sorted out before merging this PR.

The issue above fixed itself 🤷🏽‍♀️

Test it

Follow the instructions in the example's README

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from mayman99 May 27, 2022 19:40
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #407 (ca622af) into ign-gui3 (9b27bec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           ign-gui3     #407      +/-   ##
============================================
+ Coverage     66.10%   66.12%   +0.02%     
============================================
  Files            29       29              
  Lines          3216     3218       +2     
============================================
+ Hits           2126     2128       +2     
  Misses         1090     1090              
Impacted Files Coverage Δ
src/Application.cc 87.50% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b27bec...ca622af. Read the comment docs.

@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Jun 28, 2022
@chapulina chapulina marked this pull request as ready for review June 28, 2022 16:37
@chapulina chapulina requested a review from jennuine as a code owner June 28, 2022 16:37
Copy link
Contributor

@mayman99 mayman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The InitializeMainWindow seems to still be public here, but I guess this is okay because it is changed in #418

@chapulina chapulina merged commit 27afc95 into ign-gui3 Jun 30, 2022
@chapulina chapulina deleted the chapulina/3/start_dialog branch June 30, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants