Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Upstream Macro Migration : gz-gui #413

Merged
merged 9 commits into from
Jun 18, 2022
Merged

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label Jun 6, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 7, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once upstream PRs are merged and CI is happy 🟢

src/Plugin.cc Outdated Show resolved Hide resolved
src/Plugin.cc Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the macro_migration branch 2 times, most recently from 4846ffb to fe59859 Compare June 9, 2022 20:20
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
@chapulina
Copy link
Contributor

@osrf-jenkins run tests please!

Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #413 (2b1ed0a) into main (2c5d186) will increase coverage by 34.08%.
The diff coverage is 48.22%.

@@             Coverage Diff             @@
##             main     #413       +/-   ##
===========================================
+ Coverage   30.03%   64.12%   +34.08%     
===========================================
  Files          43       45        +2     
  Lines        1888     5527     +3639     
===========================================
+ Hits          567     3544     +2977     
- Misses       1321     1983      +662     
Impacted Files Coverage Δ
include/gz/gui/GuiEvents.hh 100.00% <ø> (ø)
include/gz/gui/Helpers.hh 77.77% <ø> (ø)
include/gz/gui/MainWindow.hh 100.00% <ø> (ø)
include/gz/gui/Plugin.hh 100.00% <ø> (ø)
src/Dialog.cc 68.42% <0.00%> (ø)
src/DragDropModel.cc 100.00% <ø> (ø)
src/SearchModel.cc 96.55% <ø> (ø)
...interactive_view_control/InteractiveViewControl.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalScene.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalSceneRhi.cc 0.00% <ø> (ø)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d421cfa...2b1ed0a. Read the comment docs.

@methylDragon methylDragon merged commit 9afab1e into main Jun 18, 2022
@methylDragon methylDragon deleted the macro_migration branch June 18, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants