Fix image display test #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenn Nguyen <[email protected]>
jennuine
force-pushed
the
jennuine/fix_image_test
branch
from
a2cd16f
to
dd2bd94
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #468 +/- ##
============================================
+ Coverage 69.81% 73.51% +3.70%
============================================
Files 29 30 +1
Lines 3273 3270 -3
============================================
+ Hits 2285 2404 +119
+ Misses 988 866 -122
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chapulina
added
QA
chapulina
approved these changes
Aug 16, 2022
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
|
@ahcorde do you mind taking a second look since I added more tests since @chapulina approved and she's on vacation now |
ahcorde
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of gazebosim/gz-sim#1575
Summary
Fixed the
ImageDisplay_TESTto increase code coverageChecklist
- [ ] Updated documentation (as needed)- [ ] Updated migration guide (as needed)- [ ] Consider updating Python bindings (if the library has them)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.