Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointer check in Application::RemovePlugin #501

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Nov 10, 2022

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Summary

Adds a pointer check in the Application::RemovePlugin function

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #501 (16c5f74) into ign-gui3 (b09d084) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 16c5f74 differs from pull request most recent head 42b9b20. Consider uploading reports for the commit 42b9b20 to get more accurate results

@@            Coverage Diff            @@
##           ign-gui3     #501   +/-   ##
=========================================
  Coverage     73.82%   73.82%           
=========================================
  Files            30       30           
  Lines          3270     3270           
=========================================
  Hits           2414     2414           
  Misses          856      856           
Impacted Files Coverage Δ
src/Application.cc 87.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennuine jennuine merged commit 721eca0 into ign-gui3 Nov 11, 2022
@jennuine jennuine deleted the nkoenig/pointer-check branch November 11, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants