port: 6 -> 7 2022-12-07 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a reference visual to help visualize the anchor point for view control operations. The implementation is done in gz-gui instead of gz-rendering as it's easier to do since we need to toggle visibility depending on mouse events, and also we don't need to write the same code twice for different view controllers. Signed-off-by: Ian Chen <[email protected]>
Fixes large / unexpected camera movement when orbiting / panning due to missing mouse events. Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Jenn Nguyen <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-gui7 #510 +/- ##
===========================================
+ Coverage 69.03% 69.11% +0.08%
===========================================
Files 44 44
Lines 4831 4919 +88
===========================================
+ Hits 3335 3400 +65
- Misses 1496 1519 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
the homebrew |
ahcorde
approved these changes
Dec 7, 2022
mjcarroll
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-gui6 to gz-gui7
Branch comparison: gz-gui7...ign-gui6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)