Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Camera FPS plugin #523

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Add Camera FPS plugin #523

merged 2 commits into from
Mar 17, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 16, 2023

🎉 New feature

Summary

Adds a simple camera FPS plugin to show the GUI camera's framerate

The background is made transparent so you can configure it to be floating on top of the 3d window, e.g.
camera_fps

Note: It's probably more accurate to put the logic for computing the FPS values inside the Minimal Scene plugin but I created a new Camera FPS plugin for modularity. In the Camera FPS plugin, technically it's measuring the rate at which render events are fired by the Minimal Scene plugin which happens after each GUI camera render update. I measured the difference between computing the FPS from inside the Minimal Scene plugin and also here in the Camera FPS plugin and found the difference to be < 1e-2 which is somewhat acceptable.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from jennuine as a code owner March 16, 2023 20:20
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 16, 2023
@iche033 iche033 changed the base branch from gz-gui7 to ign-gui6 March 16, 2023 20:20
@iche033 iche033 changed the title Add Camera Add Camera FPS plugin Mar 16, 2023
src/plugins/camera_fps/CameraFps.hh Outdated Show resolved Hide resolved
src/plugins/camera_fps/CameraFps.qml Show resolved Hide resolved
@iche033 iche033 added 🏯 fortress Ignition Fortress and removed 🌱 garden Ignition Garden labels Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #523 (9f34f35) into ign-gui6 (eef51bf) will not change coverage.
The diff coverage is n/a.

❗ Current head 9f34f35 differs from pull request most recent head 22c611f. Consider uploading reports for the commit 22c611f to get more accurate results

@@            Coverage Diff            @@
##           ign-gui6     #523   +/-   ##
=========================================
  Coverage     68.06%   68.06%           
=========================================
  Files            39       39           
  Lines          5327     5327           
=========================================
  Hits           3626     3626           
  Misses         1701     1701           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennuine jennuine merged commit 8f415f3 into ign-gui6 Mar 17, 2023
@jennuine jennuine deleted the camera_fps branch March 17, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants