Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TopicInfo deprecation warnings #543

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 5, 2023

🦟 Bug fix

A new TopicInfo function with an extra arg was added in gazebosim/gz-transport#384 and the existing one is now deprecated. This PR switches to use the new overloaded TopicInfo function.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from jennuine as a code owner June 5, 2023 22:32
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 5, 2023
@iche033 iche033 merged commit 8006a56 into main Jun 6, 2023
@iche033 iche033 deleted the topicinfo_deprecation_warnings branch June 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants