Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign-gui2] Workflow updates #56

Merged
merged 3 commits into from
May 7, 2020
Merged

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label May 3, 2020
@chapulina chapulina requested a review from maryaB-osr May 4, 2020 17:47
Copy link
Contributor

@maryaB-osr maryaB-osr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Tests are running, but only a fraction of them pass due to #58. Coverage reports are being generated, but like a few other libraries, Codecov is mysteriously not commenting back.

We shouldn't block this PR because of these.

@codecov-io
Copy link

codecov-io commented May 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (ign-gui2@a9284b5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             ign-gui2      #56   +/-   ##
===========================================
  Coverage            ?   14.56%           
===========================================
  Files               ?       13           
  Lines               ?     1332           
  Branches            ?        0           
===========================================
  Hits                ?      194           
  Misses              ?     1138           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9284b5...b668f53. Read the comment docs.

@chapulina
Copy link
Contributor Author

Codecov is mysteriously not commenting back.

Oh hey! Codecov is mysteriously commenting back!

@chapulina chapulina merged commit cc97a8a into ign-gui2 May 7, 2020
@chapulina chapulina deleted the workflow_updates_ign-gui2 branch May 7, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants