Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master ➡️ 2 #72

Merged
merged 3 commits into from
Jun 12, 2020
Merged

master ➡️ 2 #72

merged 3 commits into from
Jun 12, 2020

Conversation

chapulina
Copy link
Contributor

@Sarath18 @chapulina
Close plugin menu after a plugin has been added (#60)
c1d5e45 
Signed-off-by: Sarathkrishnan Ramesh <[email protected]>
@Sarath18 @chapulina
Add color palette to plugin settings to change background color (#62)
e301930 
* Add color palette to plugin settings to change background color
* Save plugin background color information in config file

Signed-off-by: Sarathkrishnan Ramesh <[email protected]>
@Sarath18 @chapulina
Sort GUI plugins alphabetically (#71)
9ecbe70 
Signed-off-by: Sarathkrishnan Ramesh <[email protected]>
@chapulina chapulina self-assigned this Jun 4, 2020
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020 •
edited
Loading

Codecov Report

Merging #72 into ign-gui2 will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui2      #72      +/-   ##
============================================
- Coverage     14.56%   14.55%   -0.02%     
============================================
  Files            13       13              
  Lines          1332     1333       +1     
============================================
  Hits            194      194              
- Misses         1138     1139       +1
Impacted Files Coverage Δ
src/MainWindow.cc 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc97a8a...9ecbe70. Read the comment docs.

@chapulina chapulina requested a review from caguero June 8, 2020 18:44
caguero
caguero approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chapulina chapulina merged commit f2388ac into ign-gui2 Jun 12, 2020
@chapulina chapulina deleted the master_to_2 branch June 12, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees

@chapulina chapulina

Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @caguero @Sarath18