KeyPublisher

[mohamedsayed18]

a plugin that publish the key strokes of the keyboard with type Int32

[chapulina]

Works great! I left several comments, mainly related to style.

We're trying to get better about documenting features as we add them. So how about adding an example config that uses this plugin to examples/config, and documenting it in this tutorial? This config worked for me:

<?xml version="1.0"?>
  
<plugin filename="KeyPublisher">
</plugin>
  
<plugin filename="TopicEcho">
</plugin>

Then you open with ign gui -c path_to_config, type the correct topic in the Topic Echo plugin and you see the key messages!

[chapulina]

This is working great, thanks for refactoring!

Just a couple more things left:

---

There are some codechecker errors left, you can check it locally too:

$ bash ./tools/code_check.sh 
./src/plugins/KeyPublisher.cc:23:  Found C system header after C++ system header. Should be: KeyPublisher.h, c system, c++ system, other.  [build/include_order] [4]
./src/plugins/KeyPublisher.cc:37:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
./src/plugins/KeyPublisher.cc:60:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
./include/ignition/gui/plugins/KeyPublisher.hh:35:  Should have a space between // and comment  [whitespace/comments] [4]
./include/ignition/gui/plugins/KeyPublisher.hh:44:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
./include/ignition/gui/plugins/KeyPublisher.hh:48:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
Total errors found: 6

---

Also, mind adding an item to this tutorial for the user to run the example config, change the echo topic to /keyboard/keypress and see the keys being published? Thanks!

[chapulina]

Works great! I pushed one last cppcheck fix and the tutorial note on 8df6f35