Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed left menu events #85

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Fixed left menu events #85

merged 2 commits into from
Jun 23, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 22, 2020

In Ubuntu 20.04 the lef menu is not working.

fail-gazebo

Probably because the keyword action is reserved. With this small fix the menu is working again.

Signed-off-by: ahcorde [email protected]

@ahcorde
Fixed left menu events
dd85beb 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde added bug Something isn't working 🔮 dome Ignition Dome labels Jun 22, 2020
@ahcorde ahcorde requested a review from chapulina June 22, 2020 20:26
@ahcorde ahcorde self-assigned this Jun 22, 2020
@ahcorde ahcorde mentioned this pull request Jun 22, 2020
Merged
@codecov
Copy link

codecov bot commented Jun 22, 2020 •
edited
Loading

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   14.55%   14.55%           
=======================================
  Files          13       13           
  Lines        1333     1333           
=======================================
  Hits          194      194           
  Misses       1139     1139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75404e2...ed0ca1a. Read the comment docs.

chapulina
chapulina suggested changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find and fix! Thanks! Only one tiny nitpick 😇 QML properties are all camelCased, mind changing this to actionElement? Thanks!

@ahcorde
camelCase
ed0ca1a 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde requested a review from chapulina June 23, 2020 06:44
@ahcorde
Copy link
Contributor Author

ahcorde commented Jun 23, 2020

🤦 Fixed

@chapulina chapulina merged commit 8144309 into master Jun 23, 2020
@chapulina chapulina deleted the ahcorde/fix/left_menu branch June 23, 2020 21:37
chapulina pushed a commit that referenced this pull request Aug 29, 2020
@ahcorde @chapulina
Fixed left menu events (#85)
0543c8e 
Signed-off-by: ahcorde <[email protected]>
chapulina pushed a commit that referenced this pull request Aug 31, 2020
@ahcorde @chapulina
Fixed left menu events (#85)
d40a938 
Signed-off-by: ahcorde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
bug Something isn't working 🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @chapulina