Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ImageDisplay in Ubuntu 20.04 #88

Merged
merged 3 commits into from
Jul 1, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 26, 2020

I was not able to visualize images with the ign gui display in Ubuntu 20.04.

Something happens using the same name for the id and for the function card(). I renamed the variable card to cardPane, with this change images are shown again with ImageDisplay Plugin.

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added the bug Something isn't working label Jun 26, 2020
@ahcorde ahcorde requested a review from chapulina as a code owner June 26, 2020 15:38
@ahcorde ahcorde self-assigned this Jun 26, 2020
@ahcorde ahcorde changed the title Fixed cameraDisplay in Ubuntu 20.04 Fixed ImageDisplay in Ubuntu 20.04 Jun 26, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   14.55%   14.55%           
=======================================
  Files          13       13           
  Lines        1333     1333           
=======================================
  Hits          194      194           
  Misses       1139     1139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8144309...74a9d4b. Read the comment docs.

Signed-off-by: ahcorde <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the card was not working on Focal and this fixes it. Thanks!

@chapulina chapulina merged commit ee09054 into master Jul 1, 2020
@chapulina chapulina deleted the ahcorde/fix/camera_visualizer branch July 1, 2020 00:52
chapulina pushed a commit that referenced this pull request Aug 29, 2020
chapulina pushed a commit that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants