Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu Jammy CI #297

Closed
wants to merge 2 commits into from
Closed

Ubuntu Jammy CI #297

wants to merge 2 commits into from

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Enable Jammy CI so we can test using the latest tooling.

One downside of doing it this early is that we don't have Jammy packages on https://packages.osrfoundation.org yet, so we have to rely on the upstream version of ign-cmake. Because the upstream package has a different name, that forces us to split the dependencies for Bionic / Focal / Jammy. Once we have libignition-cmake2-dev on our repo, I think we should use that on CI and revert the changes to packages*.apt.

That's to say I'm not convinced it's a good idea to merge this PR now, but I thought I'd open it to start a conversation.

Test it

See CI results.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Dec 3, 2021
@chapulina chapulina added the tests Broken or missing tests / testing infra label Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #297 (fbc638e) into ign-math6 (afd0b22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #297   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6359     6359           
==========================================
  Hits            6337     6337           
  Misses            22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd0b22...fbc638e. Read the comment docs.

@chapulina chapulina marked this pull request as draft December 10, 2021 17:22
@scpeters scpeters removed the 🌱 garden Ignition Garden label Jan 25, 2022
@scpeters
Copy link
Member

already merged in #378

@scpeters scpeters closed this Feb 25, 2022
@scpeters scpeters deleted the chapulina/6/jammy branch February 25, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants