Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OrientedBox pybind11 interface #350

Merged
merged 3 commits into from
Dec 29, 2021
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 29, 2021

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

This PR creates a OrientedBox Pybind11 interface

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández <[email protected]>
@ahcorde ahcorde self-assigned this Dec 29, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Dec 29, 2021
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #350 (b052c9c) into ign-math6 (5283016) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #350   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6380           
==========================================
  Hits            6358     6358           
  Misses            22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5283016...b052c9c. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Dec 29, 2021
src/python_pybind11/src/OrientedBox.hh Outdated Show resolved Hide resolved
src/python_pybind11/src/_ignition_math_pybind11.cc Outdated Show resolved Hide resolved
@ahcorde ahcorde enabled auto-merge (squash) December 29, 2021 19:41
@ahcorde ahcorde merged commit 5d2f924 into ign-math6 Dec 29, 2021
@ahcorde ahcorde deleted the ahcorde/pybind11/orientedBox branch December 29, 2021 19:42
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants