Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a validity check for Sessions created using the TimeVaryingVolumetricGrid #551

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Adds a validity check for Sessions created using the TimeVaryingVolumetricGrid #551

merged 4 commits into from
Aug 29, 2023

Commits on Aug 28, 2023

  1. Adds a validity check for Sessions created using the 

    `TimeVaryingVolumetricGrid`

This is needed to resolve a bug in gazebosim/gz-sim#1842 (review). In particular part of the issue is poor API design. Ideally `CreateSession` would return an `Option<Session>`, however it returns a `Session` even if it is not possible to create the session (for instance if it is too far ahead in time or an empty grid). Hence downstream users need a way to verify session validity.

Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9a595cd View commit details
    Browse the repository at this point in the history

  2. Style 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    840d26f View commit details
    Browse the repository at this point in the history

  3. Yeet that warning 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c49e087 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Removed commented code 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    63abc22 View commit details
    Browse the repository at this point in the history