Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 24.04 CI on harmonic #590

Merged
merged 2 commits into from
May 2, 2024
Merged

Enable 24.04 CI on harmonic #590

merged 2 commits into from
May 2, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented May 2, 2024

🎉 New feature

Attempting to enable CI on 24.04 for Harmonic (partial backport of #587)

Summary

The python3-distutils package is not available on 24.04, but we only use it in a codepath for old versions of cmake. Since 24.04 has a new enough version of cmake, that package is moved from the generic package.apt file to distro-specific packages-focal.apt and packages-jammy.apt files.

  • Don't install python3-distutils on 24.04
  • Remove old ruby cmake code

Test it

Observe CI results.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* Don't install python3-distutils on 24.04
* Remove old ruby cmake code

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (11caaf7) to head (04e3669).
Report is 4 commits behind head on gz-math7.

❗ Current head 04e3669 differs from pull request most recent head 355780f. Consider uploading reports for the commit 355780f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           gz-math7     #590   +/-   ##
=========================================
  Coverage     94.11%   94.11%           
=========================================
  Files           146      146           
  Lines          9809     9809           
=========================================
  Hits           9232     9232           
  Misses          577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1 @@
python3-distutils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need it in Jammy either (see gazebosim/gz-sim#2374 (comment))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right; I knew we need it for focal and wasn't thinking clearly about jammy. removed in 355780f

@scpeters scpeters merged commit 02e37a6 into gz-math7 May 2, 2024
13 checks passed
@scpeters scpeters deleted the scpeters/noble_harmonic branch May 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants