Few clangtidy fixes (#343)

Signed-off-by: Shameek Ganguly <[email protected]>
gazebosim · May 19, 2023 · 7d5ef01 · 7d5ef01
1 parent 8df3015
commit 7d5ef01
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/src/Filesystem.cc b/src/Filesystem.cc
@@ -220,7 +220,7 @@ namespace gz
 #endif // _WIN32
 
  //////////////////////////////////////////////////
- const std::string separator(const std::string &_p)
+ std::string separator(const std::string &_p)
  {
  return _p + preferred_separator;
  }

diff --git a/src/Generator.cc b/src/Generator.cc
@@ -149,7 +149,7 @@ bool Generator::Generate(const FileDescriptor *_file,
 
  auto ns = getNamespaces(_file->package());
 
- for (auto name : ns)
+ for (const auto name : ns)
  printer.PrintRaw("namespace " + name + " {\n");
 
  for (auto i = 0; i < _file->message_type_count(); ++i)

diff --git a/src/Generator.hh b/src/Generator.hh
@@ -25,8 +25,6 @@ namespace google {
 namespace protobuf {
 namespace compiler {
 namespace cpp {
-class GeneratorContext;
-
 /// \cond
 /// \brief Google protobuf message generator for igntion::msgs
 class Generator : public CodeGenerator