Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add light map field to material.proto #109

Closed
iche033 opened this issue Dec 10, 2020 · 2 comments
Closed

Add light map field to material.proto #109

iche033 opened this issue Dec 10, 2020 · 2 comments
Assignees
@nkoenig
Labels
enhancement New feature or request

Comments

@iche033
Copy link
Contributor

iche033 commented Dec 10, 2020

needed by ign-gazebo so we can convert the lightmap uri in SDF DOM to protobuf msgs and vice versa.

This would be an ABI breaking change.

Related pull request: gazebosim/gz-sim#471
@iche033 iche033 added the enhancement New feature or request label Dec 10, 2020
@iche033 iche033 mentioned this issue Dec 10, 2020
Merged
@chapulina
Copy link
Contributor

If #108 gets in and we end up deciding to use ign-msgs7 on Edifice, we could get this in too.

@nkoenig nkoenig self-assigned this Dec 14, 2020
@nkoenig nkoenig mentioned this issue Dec 14, 2020
Merged
@chapulina
Copy link
Contributor

Edifice will use ign-msgs7. This was addressed on #111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkoenig nkoenig

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkoenig @iche033 @chapulina