Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows installation; move installation in README to tutorial #126

Merged
merged 7 commits into from
Jan 21, 2021

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Jan 14, 2021

Retarget of #122 to ign-msgs5 via cherry-pick.
Plus standardize tutorial to be uniform with ign-common.

Copy of description:

Partially addresses gazebosim/docs#117 and gazebosim/docs#14 (comment) .

TODO: The installation URL in README currently links to ign-msgs tutorials main page, since the installation tutorial webpage doesn't exist yet. Somebody should change the link after this PR is deployed. Trivial fix.

Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #126 (d7b6d6b) into ign-msgs5 (b9fc0a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs5     #126   +/-   ##
==========================================
  Coverage      84.38%   84.38%           
==========================================
  Files              7        7           
  Lines            807      807           
==========================================
  Hits             681      681           
  Misses           126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fc0a4...d7b6d6b. Read the comment docs.

mabelzhang and others added 3 commits January 14, 2021 01:39
Signed-off-by: Mabel Zhang <[email protected]>
nit
Signed-off-by: John Shepherd <[email protected]>
John Shepherd added 2 commits January 20, 2021 12:54
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 merged commit 3baee04 into ign-msgs5 Jan 21, 2021
@JShep1 JShep1 deleted the mabelzhang/windows_install_msgs5 branch January 21, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants