Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add std:: to strings in Generator.cc/hh #129

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Add std:: to strings in Generator.cc/hh #129

merged 1 commit into from
Jan 27, 2021

Conversation

mahiuchun
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jan 27, 2021
chapulina
chapulina approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@chapulina chapulina merged commit da885b4 into gazebosim:ign-msgs6 Jan 27, 2021
@LilyWangLL
Copy link

@chapulina Why not sync up this change to other versions of msgs?

@LilyWangLL LilyWangLL mentioned this pull request Jun 28, 2022
Merged
@chapulina
Copy link
Contributor

Why not sync up this change to other versions of msgs?

This was merged forward to msgs7 in #134, and included in all subsequent major versions.

And this separate PR fixed it for msgs5: #242

What version are you interested in? The only other supported version that hasn't been covered yet is msgs1. Anyone could open a PR backporting to that.

@LilyWangLL
Copy link

Why not sync up this change to other versions of msgs?

This was merged forward to msgs7 in #134, and included in all subsequent major versions.

And this separate PR fixed it for msgs5: #242

What version are you interested in? The only other supported version that hasn't been covered yet is msgs1. Anyone could open a PR backporting to that.

Due to msgs1 msgs5 msgs6 have been added into vcpkg, so we need sync up this fix to them on vcpkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahiuchun @LilyWangLL @chapulina