Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignition version of nav_msgs/OccupancyGrid #138

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Add ignition version of nav_msgs/OccupancyGrid #138

merged 4 commits into from
Mar 1, 2021

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Feb 26, 2021 •
edited
Loading

🎉 Add Ignition version on nav_msgs/OccupancyGrid

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@mjcarroll mjcarroll self-assigned this Feb 26, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021 •
edited
Loading

Codecov Report

Merging #138 (a24dce7) into ign-msgs6 (e270983) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs6     #138   +/-   ##
==========================================
  Coverage      84.59%   84.59%           
==========================================
  Files              7        7           
  Lines            818      818           
==========================================
  Hits             692      692           
  Misses           126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e270983...a24dce7. Read the comment docs.

@mjcarroll
Add map_load_time
f904cd1 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Merge branch 'feature/occupancy_grid' of ssh:/ignitionrob…
a24dce7 
…otics/ign-msgs into feature/occupancy_grid
@chapulina chapulina mentioned this pull request Feb 27, 2021
Merged
3 tasks
@nkoenig nkoenig merged commit c2ce19d into ign-msgs6 Mar 1, 2021
@nkoenig nkoenig deleted the feature/occupancy_grid branch March 1, 2021 15:35
mjcarroll added a commit that referenced this pull request Mar 15, 2021
@mjcarroll
Add ignition version of nav_msgs/OccupancyGrid (#138)
91f37e0 
* Add ignition version of nav_msgs/OccupancyGrid

Signed-off-by: Michael Carroll <[email protected]>

* Add map_load_time

Signed-off-by: Michael Carroll <[email protected]>
chapulina pushed a commit that referenced this pull request Mar 15, 2021
@mjcarroll
Add ignition version of nav_msgs/OccupancyGrid (#138) (#143)
c0af147 
Signed-off-by: Michael Carroll <[email protected]>
@sloretz sloretz mentioned this pull request Aug 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

@ahcorde ahcorde ahcorde approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees

@mjcarroll mjcarroll

Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @nkoenig @ahcorde