Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change is_light_on to is_light_off #228

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 11, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

applied suggestion from this comment: #223 (comment)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from chapulina March 11, 2022 12:00
@ahcorde ahcorde requested a review from caguero as a code owner March 11, 2022 12:00
@ahcorde ahcorde self-assigned this Mar 11, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #228 (1adda38) into main (c154be2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files           9        9           
  Lines         956      956           
=======================================
  Hits          817      817           
  Misses        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c154be2...1adda38. Read the comment docs.

@chapulina chapulina merged commit 8462930 into main Mar 11, 2022
@chapulina chapulina deleted the ahcorde/light/is_light_off branch March 11, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants