Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo REGRESION/REGRESSION #247

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 15, 2022

🦟 Bug fix

Fixes a typo in the CMake scripts

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #247 (9dce5ae) into ign-msgs5 (914e7a3) will decrease coverage by 72.33%.
The diff coverage is n/a.

❗ Current head 9dce5ae differs from pull request most recent head b6cdbb3. Consider uploading reports for the commit b6cdbb3 to get more accurate results

@@              Coverage Diff               @@
##           ign-msgs5     #247       +/-   ##
==============================================
- Coverage      85.27%   12.93%   -72.34%     
==============================================
  Files              9      346      +337     
  Lines            903    60130    +59227     
==============================================
+ Hits             770     7779     +7009     
- Misses           133    52351    +52218     
Impacted Files Coverage Δ
src/Filesystem.cc
src/ign.cc
src/Generator.cc
src/Utility.cc
include/ignition/msgs/PointCloudPackedUtils.hh
src/Factory.cc
src/generator_main.cc
...lude/ignition/msgs/detail/PointCloudPackedUtils.hh
include/ignition/msgs/Factory.hh
include/ignition/msgs/light.pb.h 0.00% <0.00%> (ø)
... and 345 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914e7a3...b6cdbb3. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Silvio! Mind signing the commit for the DCO checker? Thanks

@traversaro
Copy link
Contributor Author

Sure, I created the change via the web interface, as soon as I have a terminal I will amend the commit.

@traversaro
Copy link
Contributor Author

Sure, I created the change via the web interface, as soon as I have a terminal I will amend the commit.

Done, sorry for the delay (I had a terminal a bit sooner than now, I just forgot do to it :D )

@chapulina chapulina merged commit 24de861 into gazebosim:ign-msgs5 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants