Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[garden] Added shininess to material message #251

Merged
merged 9 commits into from
Jun 7, 2022

Conversation

WilliamLewww
Copy link
Contributor

🎉 New feature

Depends on:

Summary

Adds the shininess data member to material.proto. The new data member is required for setting the shininess value to visuals in gz-sim.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #251 (aaeee10) into main (2770d34) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head aaeee10 differs from pull request most recent head 3c2943b. Consider uploading reports for the commit 3c2943b to get more accurate results

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   15.90%   15.90%   -0.01%     
==========================================
  Files         382      382              
  Lines       71409    71427      +18     
==========================================
  Hits        11361    11361              
- Misses      60048    60066      +18     
Impacted Files Coverage Δ
include/gz/msgs/odometry_with_covariance.pb.h
include/gz/msgs/test.pb.cc
include/gz/msgs/topic_info.pb.h
include/gz/msgs/sensor.pb.h
include/gz/msgs/bytes.pb.h
include/gz/msgs/pose_with_covariance.pb.h
include/gz/msgs/gps.pb.h
include/gz/msgs/odometry.pb.cc
include/gz/msgs/sky.pb.cc
include/gz/msgs/magnetometer_sensor.pb.h
... and 754 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2770d34...3c2943b. Read the comment docs.

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 12, 2022
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 14, 2022
WilliamLewww and others added 7 commits May 25, 2022 09:58
Signed-off-by: William Lew <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: William Lew <[email protected]>
@chapulina chapulina merged commit 0522d08 into gazebosim:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants