Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity wrench message #274

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Add entity wrench message #274

merged 3 commits into from
Jul 18, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 14, 2022

🎉 New feature

Summary

This message can be used to:

  • Define a wrench to be applied to an entity, see New Apply Link Wrench system gz-sim#1593
  • Describing the wrench that's applied to an entity. That's the use case for the message added in Add wrench visual message #200. The differences are:
    • This message doesn't have a pos field, because I think it's duplicate from wrench.force_offset.
    • This message doesn't have a label field. I have a feeling that information like which plugin is applying a force is better left to the header.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from caguero as a code owner July 14, 2022 23:43
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 14, 2022
@chapulina chapulina added MBARI buoy Sponsored by MBARI buoy sim project: https:/osrf/buoy_sim and removed 🏯 fortress Ignition Fortress labels Jul 14, 2022
@chapulina chapulina changed the base branch from ign-msgs8 to ign-msgs5 July 14, 2022 23:44
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #274 (b9b492c) into ign-msgs5 (1c6da4d) will not change coverage.
The diff coverage is n/a.

❗ Current head b9b492c differs from pull request most recent head 92b2395. Consider uploading reports for the commit 92b2395 to get more accurate results

@@            Coverage Diff             @@
##           ign-msgs5     #274   +/-   ##
==========================================
  Coverage      85.27%   85.27%           
==========================================
  Files              9        9           
  Lines            903      903           
==========================================
  Hits             770      770           
  Misses           133      133           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c6da4d...92b2395. Read the comment docs.

@arjo129
Copy link
Contributor

arjo129 commented Jul 18, 2022

That sounds like a reasonable approach. I'll rebase my work to target garden using this message.

@jennuine jennuine merged commit 16647bf into ign-msgs5 Jul 18, 2022
@jennuine jennuine deleted the chapulina/5/wrench branch July 18, 2022 16:21
chapulina added a commit that referenced this pull request Jul 18, 2022
chapulina added a commit that referenced this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel MBARI buoy Sponsored by MBARI buoy sim project: https:/osrf/buoy_sim
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants