Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign to gz] Factory::New accept ignition with warning #281

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

chapulina
Copy link
Contributor

Summary

Accept ignition messages on Factory::New, print warning and return gz equivalent.

Test it

Try sending an ignition message, see that it's sent, and a warning is printed.

ign topic -t /model/joint/thruster4_joint/cmd_thrust -m ignition.msgs.Double -p 'data: 5'
Trying to create deprecated message type [ignition.msgs.Double]. Use [gz.msgs.Double] instead.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisionally approving if the comment I left earlier can be disregarded :o

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #281 (831525e) into main (0a09d3d) will decrease coverage by 0.97%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   85.59%   84.62%   -0.98%     
==========================================
  Files          10       10              
  Lines         972      995      +23     
==========================================
+ Hits          832      842      +10     
- Misses        140      153      +13     
Impacted Files Coverage Δ
include/gz/msgs/Factory.hh 66.66% <60.00%> (-33.34%) ⬇️
src/Factory.cc 81.18% <64.00%> (-7.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a09d3d...831525e. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina enabled auto-merge (squash) July 20, 2022 16:25
include/gz/msgs/Factory.hh Outdated Show resolved Hide resolved
include/gz/msgs/Factory.hh Outdated Show resolved Hide resolved
@chapulina chapulina added the bug Something isn't working label Jul 23, 2022
@chapulina chapulina merged commit 717d39f into main Jul 25, 2022
@chapulina chapulina deleted the chapulina/7/new_ign branch July 25, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants