Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer move/rename for Windows #285

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

Fix an issue where multiple builds of the same workspace on Windows can end in error. Windows won't allow you to rename a file over a file that is already existing. As an adjustment, this checks for previous built output and removes it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from caguero as a code owner July 26, 2022 19:40
@mjcarroll mjcarroll self-assigned this Jul 26, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #285 (3d54250) into main (805c3e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   84.62%   84.62%           
=======================================
  Files          10       10           
  Lines         995      995           
=======================================
  Hits          842      842           
  Misses        153      153           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805c3e5...3d54250. Read the comment docs.

@chapulina chapulina added bug Something isn't working Windows Windows support labels Jul 26, 2022
@mjcarroll mjcarroll merged commit 8194ad6 into main Jul 27, 2022
@mjcarroll mjcarroll deleted the mjcarroll/generate_error_handling branch July 27, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden Windows Windows support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants