Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect redirection header #303

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fix for abi-checker CI job split out from #301

Summary

The abi-checker job is failing for pull requests targeting gz-msgs9 (see #301 (comment)). I believe it should be fixed by removing this outdated ignition/msgs/test_config.h redirection header file, but the abi-checker job won't pass until after this is merged to gz-msgs9. As such, I've split this change into a separate PR to be merged first, and then we can rerun CI for #301, at which point it should pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters added the bug Something isn't working label Sep 14, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 14, 2022
@scpeters scpeters merged commit 4294c64 into gz-msgs9 Sep 14, 2022
@scpeters scpeters deleted the scpeters/rm_test_config_header branch September 14, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants