Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generated message to details folder #304

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 21, 2022

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Summary

Our doxygen process filters out files in in the detail folder. With the ign to gz rename, we moved all of the generated message files to a detail subfolder. This prevented them from being processed by doxygen.

This PR instead uses a details (note the plural s) folder for the generated messages.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #304 (bec5cd9) into gz-msgs9 (b09619a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           gz-msgs9     #304   +/-   ##
=========================================
  Coverage     95.41%   95.41%           
=========================================
  Files            10       10           
  Lines          1026     1026           
=========================================
  Hits            979      979           
  Misses           47       47           
Impacted Files Coverage Δ
src/Generator.cc 92.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig merged commit 063cf7a into gz-msgs9 Sep 21, 2022
@nkoenig nkoenig deleted the generated_details branch September 21, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants